Use floating-ui’s autoUpdate to handle updates of positioning #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR not only updates the
@floating-ui/domdependency to the most recent version (0.5.0) to fix some issues, but also uses theautoUpdatefunction available since version 0.3.0 to update the popper and arrow positions.This means the
vue-resizedependency and component are no longer required. To keep compatibility, theresizeevent of the popper component is now emitted after updating the position, when requested by autoUpdate.Build and tests run just fine, manual testing of the component and features (tooltips, dropdown menus etc.) with resizing of tooltips, window, repositioning elements etc. worked very well.