Add openstack_init target #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akrog
reviewed
Jan 20, 2025
nested-passthrough/Makefile
Outdated
| @@ -101,7 +101,7 @@ deploy_controlplane: ## Deploy OCP cluster using CRC, deploy OSP operators, and | |||
| $(MAKE) prepare_controlplane_config && \ | |||
| sleep 60 && \ | |||
| echo Deploying RHOSO control plane && \ | |||
| OPENSTACK_CR=$$(realpath ./out/openstack-deployment.yaml) make -C $(INSTALL_YAMLS_DIR) openstack_deploy && \ | |||
| OPENSTACK_CR=$$(realpath ./out/openstack-deployment.yaml) make -C $(INSTALL_YAMLS_DIR) openstack_init openstack_deploy && \ | |||
There was a problem hiding this comment.
I think the openstack_init should replace the existing openstack_wait that we already have.
There was a problem hiding this comment.
I replaced the openstack_wait with openstack_init. I feel like I should test this out.
lpiwowar
force-pushed
the
fix/openstack_init_target
branch
from
1dd1698 to
a8c9b95
Compare
Recently, a new target called openstack_init has been added to install_yamls [1]. This target ensures deploynment of all the openstack operators. The current state of this repository fails with the following error: no matches for kind "NetConfig" when running make deploy_controlplane. This is caused by missing CRDs in the environment because only openstack-operator is being deployed. [1] openstack-k8s-operators/install_yamls#963
lpiwowar
force-pushed
the
fix/openstack_init_target
branch
from
a8c9b95 to
f6df3aa
Compare
|
I'm marking this as Ready for review. I successfully deployed environment with the changes from this PR. I still had to replace the infra-operator image to |
Merged
|
LGTM! Thanks @lpiwowar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, a new target called openstack_init has been added to install_yamls [1]. This target ensures deploynment of all the openstack operators. The current state of this repository fails with the following error:
no matches for kind "NetConfig"
when running make deploy_controlplane. This is caused by missing CRDs in the environment because only openstack-operator is being deployed.
[1] openstack-k8s-operators/install_yamls#963