Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Dependabot issue where modified lock files are not committed. #389

Merged
merged 8 commits into from
Jan 26, 2025
Merged

Fix Dependabot issue where modified lock files are not committed. #389

merged 8 commits into from
Jan 26, 2025

Conversation

AjayKMehta
Copy link
Owner

Fixes #386

@AjayKMehta AjayKMehta self-assigned this Jan 26, 2025
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Jan 26, 2025 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  tests/Dappery.Core.Tests/packages.lock.json  25% smaller
  .github/workflows/codeql-analysis.yml Unsupported file format
  .github/workflows/infersharp.yml Unsupported file format
  .github/workflows/test.yml Unsupported file format
  tests/Dappery.Data.Tests/packages.lock.json  0% smaller

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 26, 2025 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot added the 🧪 Tests Add or update tests label Jan 26, 2025
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot added the 💥 Conflicts Merge conflicts label Jan 26, 2025
@github-actions GitHub Actions
Copy link

Summary

Line coverage Branch coverage

Assembly Line coverage Branch coverage
Dappery.Core 71.4% 61.1%
Dappery.Data 96.1% 50%
Dappery.Domain 76.1% 0%

@AjayKMehta AjayKMehta merged commit 334c739 into master Jan 26, 2025
9 checks passed
@AjayKMehta AjayKMehta deleted the fix-lock branch January 26, 2025 23:49
AjayKMehta added a commit that referenced this pull request Jan 27, 2025
@AjayKMehta
Revert "Fix Dependabot issue where modified lock files are not commit…
fbdff04 
…ted. (#389)"

This reverts commit 334c739.
AjayKMehta added a commit that referenced this pull request Jan 27, 2025
@AjayKMehta @github-actions
Alternative mechanism to fix Dependabot issue. (#390)
4118599 
* Revert "Fix Dependabot issue where modified lock files are not committed. (#389)"

This reverts commit 334c739.

* Let's try something else.

* Stage changes first 😬

* Committing changes to lock files

* Fix workflow error.

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@AjayKMehta AjayKMehta

Labels
👷 CICD 💥 Conflicts Merge conflicts 🧪 Tests Add or update tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix bad updates by Dependabot.
1 participant
@AjayKMehta