Ci: refactor pip install logic for test and lint fix #26 #27
Conversation
yihong0618
changed the title
| python -c 'import toml; open("requirements.txt.tmp", "a").write("\n".join(toml.load(open("pyproject.toml"))["project"]["optional-dependencies"]["lint"]) + "\n")' | ||
| pip install -r requirements.txt.tmp | ||
| python -c "import bcc; print(bcc.__file__)" | ||
| pip install -U pip toml |
There was a problem hiding this comment.
install the latest pip contains setuptools
There was a problem hiding this comment.
Great I didn't know about this !
| python -c "import bcc; print(bcc.__file__)" | ||
|
|
||
| - id: tests | ||
| run: | | ||
| sudo PYTHONPATH=$(pwd)/src pytest --postgresql-exec /usr/lib/postgresql/${{matrix.postgresql_version}}/bin/pg_ctl --cov --cov-report=xml | ||
| sudo pytest --postgresql-exec /usr/lib/postgresql/${{matrix.postgresql_version}}/bin/pg_ctl --cov --cov-report=xml |
There was a problem hiding this comment.
no need set PYTHONPATH here since we install the pgtracer package
Codecov ReportBase: 90.37% // Head: 94.15% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
==========================================
+ Coverage 90.37% 94.15% +3.78%
==========================================
Files 12 4 -8
Lines 1776 308 -1468
==========================================
- Hits 1605 290 -1315
+ Misses 171 18 -153 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
upload |
|
Hello, thank you for this PR ! Before I merge it, I have to bring to your attention that we just changed the license to GPL V3. If that is not a problem for you I will merge this. |
No problem! thanks |
fix: #26
refactor pip install logic for test and lint
for
pyproject.tomlrepo there is an easy way to installthis
PRmake the GitHub Actions cleaner.my passed job can check https://github.com/yihong0618/pgtracer/actions/runs/3367072889/jobs/5584216925
the reason this Actions failed is that I can not upload coverage reports to
Codecov