mypy: pglookout/config.py [BF-1560]
#103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #103 +/- ##
==========================================
- Coverage 68.00% 65.44% -2.56%
==========================================
Files 10 11 +1
Lines 972 1010 +38
Branches 170 170
==========================================
Hits 661 661
- Misses 253 291 +38
Partials 58 58
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Mulugruntz
force-pushed
the
sgiffard/BF-1560_add_typing/pglookout_config
branch
from
9ddb56f
to
5aa2bff
Compare
added 2 commits
March 22, 2023 12:25
New file to type hint the configuration. Also: - Alphabetically sort configuration keys in the `README`. This has the effect of grouping related keys closer. - Add missing key: `replication_catchup_timeout`
Mulugruntz
force-pushed
the
sgiffard/BF-1560_add_typing/pglookout_config
branch
from
5aa2bff
to
84737ad
Compare
|
This PR and the other ones related to type hinting will be handled in #106. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New file to type hint the configuration. Also:
README. This has the effect of grouping related keys closer.replication_catchup_timeout