Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply fixes from 2.2.2 #553

Merged
merged 4 commits into from
Aug 31, 2022
Merged

Apply fixes from 2.2.2 #553

merged 4 commits into from
Aug 31, 2022

Conversation

alexole
Copy link
Contributor

@alexole alexole commented Aug 19, 2022

Apply the following fixes from 2.2.2 (#552)

  • Fix hardcoded WAL file type in the upload event
  • Fix for flaky test_pause_on_disk_full
  • Fix for flaky test_surviving_pg_receivewal_hickup

Removed hardcoded WAL file type from upload event.
When test stops receivexlogs thread, the subprocess of receivexlog
after being killed might leave incomplete .partial files, which make
the restarted receivexlog stop working. Usually those incomplete files
are truncated by pghoard after restart, so this workaround should just
make test less flaky. Ideally the receivexlogs thread should do that
cleanup in case of this kind of problems.
@alexole alexole requested review from a team as code owners August 19, 2022 11:53
@codecov
Copy link

codecov bot commented Aug 19, 2022

Codecov Report

Merging #553 (8ac6038) into main (370b1f3) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 8ac6038 differs from pull request most recent head a6af381. Consider uploading reports for the commit a6af381 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #553      +/-   ##
==========================================
+ Coverage   90.76%   90.81%   +0.04%     
==========================================
  Files          30       30              
  Lines        4593     4594       +1     
==========================================
+ Hits         4169     4172       +3     
+ Misses        424      422       -2     
Impacted Files Coverage Δ
pghoard/pghoard.py 83.41% <100.00%> (+0.69%) ⬆️
pghoard/webserver.py 89.12% <0.00%> (-0.95%) ⬇️
pghoard/basebackup/base.py 85.35% <0.00%> (-0.23%) ⬇️
pghoard/walreceiver.py 97.85% <0.00%> (+0.71%) ⬆️
pghoard/fetcher.py 97.87% <0.00%> (+2.12%) ⬆️

@alexole alexole marked this pull request as draft August 19, 2022 13:46
@alexole alexole marked this pull request as ready for review August 31, 2022 09:03
@kmichel-aiven kmichel-aiven merged commit f85068c into main Aug 31, 2022
@kmichel-aiven kmichel-aiven deleted the alex-apply-2.2.2-fixes branch August 31, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants