Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): Redesign user registration flow #2218

Merged
merged 2 commits into from
Jan 19, 2024
Merged

feat(core): Redesign user registration flow #2218

merged 2 commits into from
Jan 19, 2024

Conversation

mathieu-anderson
Copy link
Contributor

Linked issue

Resolves: #2211

What kind of change does this PR introduce?

  • Bug fix
  • New feature
  • Refactor
  • Docs update
  • CI update

What is the current behavior?

Registration flow design is not harmonious with coral design

What is the new behavior?

Redesigned accordingly:

Screen.Recording.2024-01-19.at.10.10.44.mov

Other information

  • Removed the alert, as we redirect anyway
  • Remove agreement to terms

Requirements (all must be checked before review)

  • The pull request title follows our guidelines
  • Tests for the changes have been added (if relevant)
  • The latest changes from the main branch have been pulled
  • pnpm lint has been run successfully

@mathieu-anderson mathieu-anderson added Housekeeping Task for undefined date Frontend Relates to coral (react app) labels Jan 19, 2024
@mathieu-anderson mathieu-anderson self-assigned this Jan 19, 2024
programmiri
programmiri approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@programmiri programmiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 awesome, it looks great (again)

@programmiri programmiri merged commit 8c7de92 into main Jan 19, 2024
16 of 17 checks passed
@programmiri programmiri deleted the 2211-signup branch January 19, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@programmiri programmiri programmiri approved these changes

@muralibasani muralibasani Awaiting requested review from muralibasani

Assignees

@mathieu-anderson mathieu-anderson

Labels
Frontend Relates to coral (react app) Housekeeping Task for undefined date
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(core): Redesign sign up page
2 participants
@mathieu-anderson @programmiri