Version Number in Klaw from buildProperties instead of external configuration #2188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n of Klaw. This will prevent accidental incorrect configuration in the application.properties files Signed-off-by: Aindriu Lavelle <[email protected]>
| @@ -123,9 +124,6 @@ public class ManageDatabase implements ApplicationContextAware, InitializingBean | |||
| @Value("${klaw.superadmin.default.password}") | |||
| private String superAdminDefaultPwd; | |||
|
|
|||
| @Value("${klaw.version}") | |||
There was a problem hiding this comment.
can we also remove this from application.properties ?
There was a problem hiding this comment.
Yeah its a good question I left it "in case" it was used elsewhere but honestly yeah I should just remove it will take a look at that
Signed-off-by: Aindriu Lavelle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to use the build info properties to determine the build version of Klaw. This will prevent accidental incorrect configuration in the application.properties files
Linked issue
Resolves: #xxxxx
What kind of change does this PR introduce?
What is the current behavior?
Currently if an external application.properties file is not updated with the correct build info then the migration Utility does not execute appropriately. As the klaw-version and the properties version are incorrect.
What is the new behavior?
Now the klaw version will be taken from the build properties (from the pom when building) and used internally to ensure the correct version is being used.
Other information
This also prevents any issue where the klaw.version in the application.properties file is left with the placeholder that is normally replaced as part of the build.
Requirements (all must be checked before review)
mainbranch have been pulledpnpm linthas been run successfully