Retrieve Topic contents with custom option - partitionid, number of last offsets #1984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 14, 2023 17:03
Signed-off-by: muralibasani <[email protected]>
Signed-off-by: muralibasani <[email protected]>
|
Signed-off-by: muralibasani <[email protected]>
muralibasani
changed the title
aindriu-aiven
requested changes
Nov 15, 2023
| String readMessagesType, | ||
| String clusterIdentification) { | ||
| log.info( | ||
| "readEvents bootStrapServers {}, protocol {}, clusterName {}, consumerGroupId {}, topicName {},\n" |
There was a problem hiding this comment.
should we change this to debug before we merge?
| Set<TopicPartition> topicPartitionsSet = consumer.assignment(); | ||
|
|
||
| Set<TopicPartition> partitionsAssignment = new HashSet<>(); | ||
| if (offsetPosition.equals("custom")) { |
There was a problem hiding this comment.
We should make custom a constant
| @@ -252,11 +252,20 @@ public Map<String, String> getTopicEvents( | |||
| String clusterIdentification, | |||
| String topic, | |||
| String offsetId, | |||
| Integer selectedPartitionId, | |||
| Integer selectedNumberOfOffsets, | |||
| String consumerGroupId, | |||
| int tenantId) | |||
| throws KlawException { | |||
| log.info( | |||
There was a problem hiding this comment.
lets switch this to debug before we merge as well
There was a problem hiding this comment.
removed this debug.
| consumerGroupId, | ||
| topic, | ||
| offsetId, | ||
| "partitionId", |
There was a problem hiding this comment.
partitionId & selectedNumberOfOffsets can be constants
| Map<String, String> topicEvents = new TreeMap<>(); | ||
| int tenantId = commonUtilsService.getTenantId(getUserName()); | ||
| try { | ||
| KwClusters kwClusters = | ||
| manageDatabase | ||
| .getClusters(KafkaClustersType.KAFKA, tenantId) | ||
| .get(getEnvDetails(envId).getClusterId()); | ||
| if (offsetId != null && offsetId.equals("custom")) { |
There was a problem hiding this comment.
custom can re-use the constant
added 2 commits
November 16, 2023 09:19
Signed-off-by: muralibasani <[email protected]>
1 task
|
Adding the coral UI will follow this issue: #1989 The PR for this UI will be opened against this branch, and then we can merge this PR ^^ |
…ion ID and custom offset (#2006) * feat(coral): Add accessible text color for captions * feat(coral): parse getTopicEvents params correctly * feat(coral): Add custom offset filters * fix(coral): Use sensible value for partition ID placeholder * fix(coral): Add required prop to required fields * feat(coral): Add tests * fix(coral): Do not set grey-70 on tooltip text * fix(coral): Make max offset 100 * fix(coral): Add badge case to a11y label * fix(coral): Simplify legend/label color rule --------- Signed-off-by: Mathieu Anderson <[email protected]>
Signed-off-by: Mathieu Anderson <[email protected]>
Signed-off-by: muralibasani <[email protected]>
Signed-off-by: Mathieu Anderson <[email protected]>
| do { | ||
| ConsumerRecords<String, String> consumerRecords = consumer.poll(Duration.ofMillis(500)); | ||
| consumerRecords.forEach(record -> eventMap.put(record.offset(), record.value())); | ||
| i++; | ||
| } while (i != numOfEventsToRead); | ||
| } while (i != numberOfPolls); |
There was a problem hiding this comment.
Id make number of polls a class constant
Signed-off-by: Mathieu Anderson <[email protected]>
Signed-off-by: muralibasani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issue
Resolves: #1812
What kind of change does this PR introduce?
What is the current behavior?
Describe the state of the application before this PR. Illustrations appreciated (videos, gifs, screenshots).
On the Topic Overview under 'Topic Contents' kafka messages can be viewed.
Users have to only select from dropdown to view events, which is 5, 10, 50
What is the new behavior?
Describe the state of the application after this PR. Illustrations appreciated (videos, gifs, screenshots).
With this custom option, users can type in a partitionid and number of offsets to view
Other information
Additional changes, explanations of the approach taken, unresolved issues, necessary follow ups, etc.
Requirements (all must be checked before review)
mainbranch have been pulledpnpm linthas been run successfully