Update to use a type of String to make queries #1651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aindriu Lavelle <[email protected]>
| Long topicApprovalCount = | ||
| topicRequestsRepo.countRequestorsTopicRequestsGroupByStatusType( | ||
| teamId, tenantId, requestor, RequestStatus.CREATED.value); | ||
| teamId, Integer.toString(teamId), tenantId, requestor, RequestStatus.CREATED.value); |
There was a problem hiding this comment.
Do we want to have a different teamId in the second argument here
There was a problem hiding this comment.
I dont think so, the teamId is the requestors teamId and so is retriving the statistics for all topics/connector requests they are able to approve, and that aligns with what we return to the UI in terms of the connectors themselves.
There was a problem hiding this comment.
If you have another scenario I'm not thinking of though let me know!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
This change uses a string for the approving team comparison as the kafka connector and topic requests have a string type for appronving team, but an integer type for the teamId
Resolves: #xxxxx
Why this way
This allows the queries to run against the H2 and postgres (and other dbs)
Tested this against a local postgres and local H2