-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow user to force register a schema #1882
Comments
Force Register overrides the schema compatibility and allows the registering of the new schema. I kind of like it up by the warning banner but I also like it down by the submit request button |
Yes, I think so! I would then add the same text to the promotion process. At the moment, we only show the checkbox (same as it was in Angular) with the caption.
See, that was how I was feeling, that's why there are now options for it being all over the place :D |
|
Could we just have one more "Request type" called "Force register"? Then we don't need to add new column. |
This is the clearest option from all of the once you gave, so I'm happy with this :) |
"force register" can be true for different types of requests (update, promote, create), so that would not work out. |
@Taikatuuli This are two options what we could do in the table, simple text or status chip (I think the latter sounds good). ![]() ![]() |
Warning status chip is clearer! :) |
What happened?
We added a compatibility check for schemas before the schema creating (also update / promotion), but we didn't add the option for users to force register a schema even if it does not pass this check.
At the moment, users can't create a new schema if the compatibility check returns an error.
Todo
Design / Text
Form for creating / update
This are three different options how we could add this. Important: We don't show that option right away, because we don't want to encourage it. It only will show up if the api call has returned the validation error.
-> the warning will be in the place where we in all our forms usually show errors, so it's familiar to users.
-> the new checkbox is near the warning so users will see it directly
-> having the checkbox near the submit button may make it more clear that this check is needed before submitting again, it feels a bit familiar to the pattern where you e.g. have to confirm you read terms of services etc.
-> the warning is near the checkbox to highlight it more
Note: On a very small screen, user could potentially miss that elements appeared at the bottom (although the screen has to be REALLy small for this)
-> warning is where errors would appear and users should notice them better
-> checkbox is in the (maybe :D) familiar place to "confirm" something before submit
Approver table
I've no suggestion here :D this are the views where we could add that information.
I think we could add a small column in the table with header "force register" and only have a "yes" (or something like that :D) as content and then have more detailed information in the details modal, where the header is "force register" and the text more like "Yes: Force Register Schema option overriding schema compatibility has been selected." (well with a better copy).
That way, the table would not grow a lot while still providing users the information directly. In case they need more information, the detail modal will give it to them.
The text was updated successfully, but these errors were encountered: