Use S3 OIDC credentials provider #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdedetrich
force-pushed
the
use-s3-oidc-credentials-provider
branch
2 times, most recently
from
2a50e4f to
7fea342
Compare
|
PR is currently blocked by sbt/sbt-github-actions#105 |
mdedetrich
added
the
upstream
mdedetrich
force-pushed
the
use-s3-oidc-credentials-provider
branch
from
7fea342 to
4991c63
Compare
mdedetrich
force-pushed
the
use-s3-oidc-credentials-provider
branch
4 times, most recently
from
4729fc0 to
3ea6a36
Compare
mdedetrich
force-pushed
the
use-s3-oidc-credentials-provider
branch
from
3ea6a36 to
db00fc2
Compare
Pull Request Test Coverage Report for Build 5191098729
💛 - Coveralls |
mdedetrich
removed
the
upstream
mdedetrich
requested review from
reta,
jlprat,
RyanSkraba,
snuyanzin and
ahmedsobeh
reta
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
Uses AWS OIDC provider for credentials rather than raw key/secret
Why this way
Using github's secrets has the issue where if someone creates a pull request that it outside of the Aiven org (which ultimately means creating a fork) then github-actions will not expose the secrets for security reasons.
The proper way to solve this problem is to use the OIDC provider https://github.com/aws-actions/configure-aws-credentials which afaik creates the same key/secret in environment variables however those specific key/secret that is generated is temporary so even if a bad actor gets access to them they would have already been expired.
With the latest version of sbt-github-actions merged (see #410) its now possible to do this.