Make API key less likely to be logged #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change:
const at = new Airtable({ apiKey: 'keyXyz' })
console.log(at)
// => Class { _apiKey: 'keyXyz', ... }
After this change:
const at = new Airtable({ apiKey: 'keyXyz' })
console.log(at)
// => Class { ... }
This is accomplished with `Object.defineProperties`. By default,
properties defined this way aren't enumerable, making it more difficult
to accidentally log them.
Addresses <#82>.
kasrak
approved these changes
Mar 23, 2019
EvanHahn
deleted the
evanhahn-defineSensitivePropertiesWithObject.defineProperties
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change:
After this change:
This is accomplished with
Object.defineProperties. By default, properties defined this way aren't enumerable, making it more difficult to accidentally log them.Internal tests passed.
Fixes #82.