Fix: propagate errors happening in eachPage callback #283
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It happens that an error is thrown within the callback function passed to
table.select(...).eachPage(XXX)
. The previous code only recognizes network errors, With this change, errors thrown by the JS code will propagate, instead of having an obscure error:I don't know how to update the unit tests to maintain the 100% coverage. I'd be grateful if you could take the test update or advise on where/how this change should be tested.