Add test coverage for lib/run_action.js
#187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jugglinmike
reviewed
Jun 15, 2020
test/find.test.js
Outdated
| @@ -16,6 +16,7 @@ describe('record retrival', function() { | |||
| }); | |||
|
|
|||
| afterAll(function() { | |||
| delete global.x; | |||
There was a problem hiding this comment.
This should probably delete global.window
test/find.test.js
Outdated
| }); | ||
| }); | ||
|
|
||
| it('can find after a retry if rate limited', function(done) { |
|
@kasrak - Once this PR gets merged I'm ready to open up a stacked PR for changing |
kasrak
approved these changes
Jun 17, 2020
|
@rmeritz thanks! Looks like there's a conflict with |
rmeritz
force-pushed
the
run-action-tests-rmeritz
branch
from
b1d49ec to
4be1911
Compare
|
@kasrak - I fixed the merge conflict. |
kasrak
changed the title
lib/run_action.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run_actiondidn't have any unit tests but was already pretty throughly tested because almost all methods use it run make their API requests. I didn't add unit testing I just added the missing pieaces of coverage: