Complete tests for http_headers #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ignore lack of test for isBrowser because isn't very important and is hard to test because `window` is called when the file is required. - Add test for custom user-agent header
jugglinmike
approved these changes
Jun 10, 2020
| @@ -25,6 +24,7 @@ HttpHeaders.prototype.toJSON = function() { | |||
| var result = {}; | |||
| forEach(this._headersByLowercasedKey, function(headerDefinition, lowercasedKey) { | |||
| var headerKey; | |||
| /* istanbul ignore next */ | |||
| if (isBrowser && lowercasedKey === 'user-agent') { | |||
There was a problem hiding this comment.
FYI, the reason istanbul ignore if doesn't work here is that there are two branches involved. There's the body of the if statement (which is ignored by istanbul ignore if) and the second half of the condition expression, lowercasedKey === 'user-agent' (which is not ignored by istanbul ignore if).
We could switch the order of the expressions in the conditional. That would technically be more precise, but I wouldn't push for it. The current order is presumably more intuitive for the folks maintaining this code, and it's more important to support them than it is to improve a technicality in the coverage report.
kasrak
approved these changes
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hard to test because
windowis called when the file is required.