Add base.js to coverage report #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The main public functions were already tested - `#createFunctor` and `#doCall` is tested `airtable.test.js` where is is used because it probably not really meant to be a public api
rmeritz
force-pushed
the
base-tests-rmeritz
branch
from
d197d3e to
36d1fc0
Compare
kasrak
approved these changes
Jun 4, 2020
|
@kasrak neither Rebecca nor I have "write" access to this repository, so we can't merge this even with your approval. |
rmeritz
added a commit
to bocoup/airtable.js
that referenced
this pull request
Jun 10, 2020
* Update README with info about how to run tests * Complete tests for base.js - The main public functions were already tested - `#createFunctor` and `#doCall` is tested `airtable.test.js` where is is used because it probably not really meant to be a public api * Add an editorconfig file https://editorconfig.org/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_that weren't tested but I believe they are meant to be private and not tested so I ignored themgetId#doCalland#createFunctorbecause it is doubtful that they really are meant to be part of a public interface and would probably not be considered a breaking change if they were changed.#doCallisn't actually called outside oftable.jsand probably should be prefixed by an underscore.