Stop publishing non-essential files (like tests and gruntfile) to npm #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that we were publishing a bunch of unnecessary files (like the
`test` directory and `gruntfile.js`) to npm. At best, this wastes space.
At worst, we could accidentally publish some sensitive file (though
that's unlikely).
Tested this by:
1. Ran `npm pack` and verified that no unnecessary files were included
2. Copied the resulting tarbal, `airtable-0.7.0.tgz`, into a temporary
directory
3. Ran `npm i airtable-0.7.0.tgz`
4. Verified that `node -p "require('airtable')"` didn't break
See documentation for the [`files`][1] key in `package.json` for more
info here.
[1]: https://docs.npmjs.com/files/package.json#files
kasrak
approved these changes
Jul 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that we were publishing a bunch of unnecessary files (like the
testdirectory andgruntfile.js) to npm. At best, this wastes space. At worst, we could accidentally publish some sensitive file (though that's unlikely).Tested this by:
npm packand verified that no unnecessary files were includedairtable-0.7.0.tgz, into a temporary directorynpm i airtable-0.7.0.tgznode -p "require('airtable')"didn't breakSee documentation for the
fileskey inpackage.jsonfor more info here.