Remove class library, use normal prototypes #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This drops our custom class library (at `lib/class.js`) and replaces it with "normal" JavaScript prototypes. This has three benefits: 1. Things like `console.log(myRecord)` will output `Record` in the console instead of `Class`, improving developer experience 2. Shaves ~4 kilobytes off the browser build 3. Simplifies the setup (remove a library) `npm test` passes after this change.
kasrak
approved these changes
Jul 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops our custom class library (at
lib/class.js) and replaces it with "normal" JavaScript prototypes. This has three benefits:console.log(myRecord)will outputRecordin the console instead ofClass, improving developer experiencenpm testpasses after this change.The whitespace-free version of this diff is much easier to review.