-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include new branch of IRremoteESP8266 to save 21k #582
Merged
Aircoookie
merged 30 commits into
Aircoookie:master
from
Def3nder:IRremoteESP8266newBranch
Jan 10, 2020
Merged
Include new branch of IRremoteESP8266 to save 21k #582
Aircoookie
merged 30 commits into
Aircoookie:master
from
Def3nder:IRremoteESP8266newBranch
Jan 10, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When adding an RGBW device to Alexa and then selecting a white color tone, Alexa will send CT values to the device. Having a warm white or cold white strip should use 100% of that strip and then add the RGB colors to get either a warmer color or a colder one.
Added IR remote with 40 keys to use with RGBW stripes.
...not implemented for ESP32 yet ESP32 Solid RGBW defines moved from env:esp32dev to env:esp32 ESP32 Solid RGBW defines
Update readme.md
To turn off IR remote use "0" in the settings, use 1 to 4 for different IR remote types.
adapt the logic to use CW and WW for different CT-values
Changed code from #define WLED_DISABLE_ANALOG_LEDS to #define WLED_USE_ANALOG_LEDS
NightLight used to brighten the light combined with fading from the actual (primary) color to the secondary color
RLYPIN definition dependant on WLED_USE_ANALOG_LEDS Corrected list-item indents (readme.md) updated to match upstream master (briLast in wled00.ino)
RLYPIN definition dependant on WLED_USE_ANALOG_LEDS Fixed headline and corrected list-item indents (readme.md) updated to match upstream master (briLast in wled00.ino)
...where the used functions can be controlled with -D build_flags. This saves 21024 bytes of program space 😄
...where the used functions can be controlled with -D build_flags. This saves 21024 bytes of program space 😄 changed to the new branch version (this was the prove test with the old v2.7.2)
Def3nder
force-pushed
the
IRremoteESP8266newBranch
branch
from
January 10, 2020 14:20
fbaea16
to
13e84b0
Compare
Awesome, thank you for sorting that out! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Aircoookie , I did open an issue and talked with the author of the IRremoteESP8266 library.
He created a new branch "compile_flags" where the usage of the different modules can by selected at compile time with -D build flags.
So: no code changes at all - only platformio.ini changes that result in 21024 bytes smaller code 😄