This repository has been archived by the owner on Jul 2, 2024. It is now read-only.
Add changelog note for query phases #4884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Standard tests have passed ❤️ |
sebastian
approved these changes
Feb 11, 2021
|
Pull request can be merged 🎉 |
|
Hm, hang on, now the "waiting for database" is basically zero, right? This is going to fuck up the "slow queries" graph (see https://demo.aircloak.com/admin/queries/performance) |
|
Hm, ok, let's remove the states we no longer need should we ever make another release. |
Yeah, sadly this change will ripple in a lot of places. We risk breaking too many things if we start messing with the query lifecycle... |
|
Yeah, created a separate issue to keep track of this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have ran queries through all possible channels and haven't encountered any bug.
This and #4882 contain the changes for the minor release 21.1.