Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redundant parameters required by obic_field #145

Closed
BrentWHR opened this issue Sep 14, 2021 · 0 comments · Fixed by #146
Closed

Redundant parameters required by obic_field #145

BrentWHR opened this issue Sep 14, 2021 · 0 comments · Fixed by #146
Assignees
@BrentWHR

Comments

@BrentWHR
Copy link
Contributor

The following parameters are required by obic_field() and obic_field_dt() but are (no longer) used in any of the underlying functions and can therefore probably be removed from the required inputs:
A_CACO3_IF The carbonate content of the soil
A_COM_FR The carbon fraction of soil organic matter
@BrentWHR BrentWHR self-assigned this Sep 14, 2021
@BrentWHR BrentWHR mentioned this issue Sep 16, 2021
Merged
@SvenVw SvenVw linked a pull request Sep 16, 2021 that will close this issue
hotfix/v1.0.3 #146
Merged
@SvenVw SvenVw mentioned this issue Oct 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrentWHR BrentWHR

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

hotfix/v1.0.3 AgroCares/Open-Bodem-Index-Calculator
1 participant
@BrentWHR