feat(liveslots): virtual exo meta-ops #8779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erights
force-pushed
the
markm-virtual-exo-meta-ops
branch
from
6d83204 to
b2d83df
Compare
erights
force-pushed
the
markm-remove-migrated-common
branch
from
6e0290e to
ac7afd2
Compare
erights
force-pushed
the
markm-virtual-exo-meta-ops
branch
2 times, most recently
from
0992e94 to
0d46632
Compare
erights
commented
Jan 21, 2024
erights
commented
Jan 21, 2024
erights
commented
Jan 21, 2024
erights
force-pushed
the
markm-virtual-exo-meta-ops
branch
from
0d46632 to
f4be681
Compare
erights
commented
Jan 22, 2024
erights
force-pushed
the
markm-virtual-exo-meta-ops
branch
from
22dd0e6 to
2d35107
Compare
|
Not urgent. But ping in case it's easy and you have a moment ;) |
erights
force-pushed
the
markm-virtual-exo-meta-ops
branch
3 times, most recently
from
e0735f2 to
40bff44
Compare
erights
force-pushed
the
markm-virtual-exo-meta-ops
branch
from
40bff44 to
386fd27
Compare
erights
force-pushed
the
markm-virtual-exo-meta-ops
branch
2 times, most recently
from
da42d81 to
2e84bb7
Compare
erights
changed the base branch from
master
to
markm-move-revocability-to-base-zone
This was referenced Feb 23, 2024
erights
force-pushed
the
markm-move-revocability-to-base-zone
branch
from
b252dcb to
609c4df
Compare
erights
force-pushed
the
markm-virtual-exo-meta-ops
branch
from
2e84bb7 to
c0aa00b
Compare
erights
force-pushed
the
markm-move-revocability-to-base-zone
branch
from
609c4df to
9654897
Compare
erights
force-pushed
the
markm-virtual-exo-meta-ops
branch
from
c0aa00b to
c21ed44
Compare
erights
force-pushed
the
markm-move-revocability-to-base-zone
branch
from
9654897 to
da52e07
Compare
erights
force-pushed
the
markm-virtual-exo-meta-ops
branch
from
d601dd3 to
6cd1381
Compare
Base automatically changed from
markm-move-revocability-to-base-zone
to
master
February 24, 2024 03:27
erights
force-pushed
the
markm-virtual-exo-meta-ops
branch
2 times, most recently
from
aa7a58d to
e70f34e
Compare
erights
force-pushed
the
markm-virtual-exo-meta-ops
branch
from
e70f34e to
4b9dcdf
Compare
|
ping? |
erights
force-pushed
the
markm-virtual-exo-meta-ops
branch
2 times, most recently
from
812e4a2 to
1540fce
Compare
erights
commented
Mar 26, 2024
erights
commented
Mar 26, 2024
erights
commented
Mar 26, 2024
erights
force-pushed
the
markm-virtual-exo-meta-ops
branch
from
1540fce to
40250db
Compare
michaelfig
approved these changes
Mar 28, 2024
erights
force-pushed
the
markm-virtual-exo-meta-ops
branch
from
77dd4cf to
d5c2dfd
Compare
erights
force-pushed
the
markm-virtual-exo-meta-ops
branch
from
d5c2dfd to
d0b6803
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #XXXX
refs: endojs/endo#1925 endojs/endo#1924 #8965
Description
The @endo/exo package defines APIs for defining exos that are supposed to be implemented by all exo implementations. It does implement
receiveAmplifierandreceiveIsInstanceTesterfor heap exos. This PR does likewise for virtual and durable exos.@FUDCo In @endo/exo I assume contextProviders indicate the context is not found by returning
undefinedrather than throwing. My code kinda depends on that assumption. I thought it was true for both heap and virtual/durable exos. But the contextProviders here, before this PR, threw. This PR changes them to returnundefined. Is this correct? What should I worry about?Security Considerations
These meta-ops provide a form of rights amplification. But the API was specifically designed so the extra power would be easy to spot during code reviews. We need to ensure that reviewers know what to look for.
Scaling Considerations
Without these meta-ops, the same functionality can (and has been) implemented by introducing yet another weak store. When this is a virtual or durable weak store, that's quite expensive. It also introduces cyclic gc concerns. The implementation provided here avoids those costs.
Documentation Considerations
Once this PR is merged, these meta-ops are uniformly available across heap, virtual, and durable exos, as well as the zones for those. At that point, they will be ready to document and use.
Testing Considerations
The included tests are modeled on those in @endo/exo for heap exos. However, rather than copy-edit code, we should replace both with reusable zone-parameterized tests.
Upgrade Considerations
There should be no problem upgrading an exo incarnation without meta-ops to one with these meta-ops, since there is no change to the representations in virtual or durable storage.