refactor(ertp): rename reallyPrepareIssuerKit to prepareIssuerKit #8504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris-Hibbert
approved these changes
Nov 7, 2023
erights
force-pushed
the
markm-rename-to-prepare-issuer-kit
branch
from
818a328 to
2c8f2ab
Compare
Thanks. I'm gonna go ahead and merge it then. Once merged, unmerged PRs like our #8498 will need to be revised to use the new names. |
anilhelvaci
pushed a commit
to Jorge-Lopes/agoric-sdk
that referenced
this pull request
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #8497
Description
Successor to #8497 . #8497
prepareIssuerKitreallyPrepareIssuerKitas a horrible name for what should have been namedprepareIssuerKitprepareIssuerKitOnce #8497 is merged, there will be no remaining uses of the deprecated meaning of
prepareIssuerKitin this repo, so we can remove it without breaking anything in this repo.Since
reallyPrepareIssuerKitis introduced only starting with #8497 , there shouldn't be any other uses of it outside this repo, so we can rename it without preserving the old name as deprecated.The open question is when would it be safe to merge this PR wrt uses of the deprecated
prepareIssuerKitoutside this repo. Reviewers, opinions?Security Considerations
If indeed this PR by itself is a pure refactor with no observable effects, it should have no security implications.
Scaling Considerations
If indeed this PR by itself is a pure refactor with no observable effects, it should have no scaling implications.
Documentation Considerations
#8497 Documentation Considerations says
That is what this PR would do.
Testing Considerations
If indeed this PR by itself is a pure refactor with no observable effects, it should have no testing implications.
Upgrade Considerations
If indeed this PR by itself is a pure refactor with no observable effects, it should have no implications for upgrade, modulo possible version skew on uses of the old vs new names.