Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade durable-object state data and stateShape #8117

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

upgrade durable-object state data and stateShape #8117

wants to merge 4 commits into from

Conversation

warner
Copy link
Member

@warner warner commented Jul 30, 2023

first steps towards allowing durable-object state data to be upgraded in newer versions

closes #7407

@warner warner added SwingSet package: SwingSet liveslots requires vat-upgrade to deploy changes labels Jul 30, 2023
@warner warner self-assigned this Jul 30, 2023
@warner
Copy link
Member Author

warner commented Jul 30, 2023

This branch currently has docs and tests, but not the implementation.

@warner warner force-pushed the 7407-upgrade-durable-object-state branch from ef09e67 to 6dda764 Compare July 9, 2024 23:36
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jul 9, 2024 •
edited
Loading

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: c97e160
Status:🚫  Build failed.

View logs

@erights
Copy link
Member

erights commented Jul 10, 2024

Is upgrading stateShape sufficiently similar to upgrading keyShape and valueShape that they could be part of this PR or a closely following PR?

@warner warner force-pushed the 7407-upgrade-durable-object-state branch from 6dda764 to c97e160 Compare July 10, 2024 06:32
@warner
Copy link
Member Author

warner commented Jul 11, 2024

Is upgrading stateShape sufficiently similar to upgrading keyShape and valueShape that they could be part of this PR or a closely following PR?

Unfortunately no.. as #7525 points out, collections (which have keyShape and valueShape) don't have a defineKind call to run in subsequent incarnations, and no sort of "CollectionHandle" that would correspond to a KindHandle and provide the right authority to change the shapes. We don't yet have a theory of how to manage the collection upgrade.

@warner warner removed their assignment Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
liveslots requires vat-upgrade to deploy changes SwingSet package: SwingSet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lazy schema upgrade / data-migration for virtual objects
2 participants
@warner @erights