fix(xsnap): agd checks 'xsnap -n' for agoric-upgrade-10 #7831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanlei
approved these changes
May 24, 2023
warner
force-pushed
the
7012-xsnap-version-check
branch
from
1ca6d40 to
4be02e7
Compare
This is a quick hack to assert that xsnap has been recompiled recently. `bin/agd` now runs `xsnap -n` to get the "network upgrade version", and asserts that it matches an expected value of `agoric-update-10`. If a user has somehow failed to recompile `xsnap`, their old copy won't understand the `-n` command, and `agd` will fail, rather than running a stale version (with highly confusing results). refs #7012
warner
force-pushed
the
7012-xsnap-version-check
branch
from
4be02e7 to
5265726
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick hack to assert that xsnap has been recompiled recently.
bin/agdnow runsxsnap -nto get the "network upgrade version", and asserts that it matches an expected value ofagoric-update-10. If a user has somehow failed to recompilexsnap, their old copy won't understand the-ncommand, andagdwill fail, rather than running a stale version (with highly confusing results).refs #7012