board remote as remotable #7147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog ReportBranch report: ✅ |
dckc
approved these changes
Mar 9, 2023
| @@ -32,7 +32,6 @@ export const makeEconomicCommiteeCommand = async _logger => { | |||
| id: opts.offerId, | |||
| invitationSpec: { | |||
| source: 'purse', | |||
| // @ts-expect-error xxx RpcRemote | |||
packages/vats/tools/board-utils.js
Outdated
Comment on lines
44
to
47
| { boardId: latestCapData.slots[slotInfo.index], iface: slotInfo.iface }, | ||
| { getBoardId: () => latestCapData.slots[slotInfo.index] }, |
There was a problem hiding this comment.
should this be Far(slotInfo.iface, {...})?
turadg
added
automerge:no-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the
BoardRemotetype to work more like a regular remotable and thus be passed through APIs that expect real remotables.Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations