feat(cosmic-swingset): chain-level transcripts #6931
Draft
+1,087
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofman
force-pushed
the
mhofman/chain-transcript-replay-tool
branch
from
8143318 to
08e123a
Compare
michaelfig
reviewed
Feb 27, 2023
| // | ||
| // The first 3 are sinks only. bridgeOutbound returns a result (for now) | ||
| // The actionQueue is used as a synchronous iterator drained at once | ||
| const recordChainActionWrap = |
There was a problem hiding this comment.
I'd like a name that better conveyed Wrap and Record being a verb, if either or both of them are. wrapWithChainActionRecorder? makeChainActionRecordWrapper? makeChainActionRecorder?
I'm not sure but am open to your suggestion.
There was a problem hiding this comment.
Yeah naming is hard. wrapWithChainActionRecorder seems like a better fit.
recordChainActionWrap -> wrapWithChainActionRecorder
mhofman
force-pushed
the
mhofman/chain-transcript-replay-tool
branch
from
d65aba1 to
5332018
Compare
Default for wrapWithChainActionRecorder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #6920, #6929
Description
This introduces a chain-level transcript, and a "basic" tool to replay from that transcript, currently only enforcing that "bank" outbound bridge messages match (ignoring storage bridge sends).
This allows to verify that a different version of XS didn't change so dramatically that the JavaScript did different observable things. It should also allow to observe the impact of internal improvements to liveslots / swingset. Finally it may allow to observe the impact of contract changes, if their overall behavior doesn't change dramatically (same set of wallet actions results in same set of chain changes)
Security Considerations
None
Scaling Considerations
None
Documentation Considerations
Internal tooling
Testing Considerations
This is not tested per se, as most cosmic-swingset tools, but enables a variety of new testing, which we expect to make more use of, like for #6929, or future performance improvements.