5894 durable smartwallet #6871
Merged
5894 durable smartwallet #6871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
force-pushed
the
5894-durable-smartwallet
branch
from
1692979 to
f50c65a
Compare
turadg
force-pushed
the
5894-durable-smartwallet
branch
2 times, most recently
from
42c9f2d to
bee26f9
Compare
Chris-Hibbert
approved these changes
Jan 30, 2023
turadg
force-pushed
the
5894-durable-smartwallet
branch
from
8d0d2b0 to
d072f7f
Compare
turadg
force-pushed
the
5894-durable-smartwallet
branch
from
45ada35 to
6977f73
Compare
turadg
added
the
automerge:no-update
Chris-Hibbert
approved these changes
Feb 1, 2023
|
|
||
| /** @type {PublishKit<UpdateRecord>} */ | ||
| const updatePublishKit = makeWalletPublishKit(); | ||
| // NB: state size must not grow monotonically |
There was a problem hiding this comment.
I'm not sure what "must not grow monotically" means. (I realize you moved it.) Do you think it's trying to say that it "must grow sub-linearly"?
There was a problem hiding this comment.
I wrote the moved string. I mean it must not continue to grow; it must also drop information that's no longer useful.
If you propose a better way to say that I can drop it into another PR
There was a problem hiding this comment.
"state size must not grow without bound" or "state must be limited in size". Not sure which you mean.
"must not grow monotonically" sounds to me like it can reach whatever size it wants, as long as it occasionally pares things back somewhat.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #5894
Description
Makes the
walletFactorycontract durable. Upgrade deferred to #6878In support, it moves some /inter-protocol helpers down to /zoe and adds a new
provideStoredSubscriber. The latter will be replaced soon by TopicMeta tools (à la #6888 ) so this provider is designed to been drop-in replaced.It also has a drive-by fix:
makeEphemeraProviderhad a strong map for its ephemerasIn this PR I had also included d072f7f, in the spirit of POLA, but it complicated diagnostic logging so I backed it out. Looking for feedback on whether it's worth doing (and if so I'll do in a separate PR.) @dckc may have thoughts on the ocap discipline.
Security Considerations
No new assumptions. Improves POLA.
Scaling Considerations
Small additional RAM for the StoredSubscriber provider.
Documentation Considerations
--
Testing Considerations
CI and agops-oracle-smoketest.