-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(xsnap): Update Moddable SDK to 3.6.0 #6768
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DO NOT MERGE INTO MAIN BRANCH Workaround for #6588 During transcript replay, handle divergent syscalls which retrieve stable Virtual Collection metadata. These can happen at different times than recorded during the transcript because of some bugs in the XS engine making GC sensitive to reload from heap snapshots.
- @agoric/[email protected] - @agoric/[email protected] - [email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected]
chore(release): publish pismoB
Store VC metadata syscalls results for handling missing from transcript Options to configure syscall mismatch
With different load points
Add keep worker at specific delivery nums
…orkers Fix concurrent snapshot save for custom snapStore
Use recursion in simulateSyscalls Split syscallFromWorker
mhofman
force-pushed
the
mhofman/update-xs-sdk
branch
from
January 11, 2023 16:26
da47294
to
82471eb
Compare
I mangled my branches, will open a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #6759
supersedes: #6011
Description
Updates our old fork of the Moddable SDK to a newer fork based on tag 3.6.0
The fork contains 5 commit reverts which have been identified to cause unexplained behavior differences compared to our old fork.
Security Considerations
This update contains a lot of bug fixes in XS found by fuzzing tools. This should be a strict improvement.
Documentation Considerations
N/A
Testing Considerations
Extracted a transcript of all mainnet vats and replayed those on a branch of pismo with just the Moddable SDK updated to the version in this PR.