Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(xsnap): Update Moddable SDK to 3.6.0 #6768

Closed
wants to merge 35 commits into from
Closed

Conversation

mhofman
Copy link
Member

@mhofman mhofman commented Jan 10, 2023

closes: #6759
supersedes: #6011

Description

Updates our old fork of the Moddable SDK to a newer fork based on tag 3.6.0

The fork contains 5 commit reverts which have been identified to cause unexplained behavior differences compared to our old fork.

Security Considerations

This update contains a lot of bug fixes in XS found by fuzzing tools. This should be a strict improvement.

Documentation Considerations

N/A

Testing Considerations

Extracted a transcript of all mainnet vats and replayed those on a branch of pismo with just the Moddable SDK updated to the version in this PR.

mhofman and others added 29 commits December 13, 2022 17:44
DO NOT MERGE INTO MAIN BRANCH
Workaround for #6588

During transcript replay, handle divergent syscalls which retrieve
stable Virtual Collection metadata. These can happen at different times
than recorded during the transcript because of some bugs in the XS
engine making GC sensitive to reload from heap snapshots.
Store VC metadata syscalls results for handling missing from transcript
Options to configure syscall mismatch
Add keep worker at specific delivery nums
…orkers

Fix concurrent snapshot save for custom snapStore
@mhofman mhofman requested a review from warner January 10, 2023 02:30
@mhofman mhofman force-pushed the mhofman/update-xs-sdk branch from da47294 to 82471eb Compare January 11, 2023 16:26
@mhofman
Copy link
Member Author

mhofman commented Jan 11, 2023

I mangled my branches, will open a new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Synchronize with version 3.6.0 or newer of Moddable SDK
2 participants