chore(wallet-ui): remove smart wallet support from solo build #6497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsiegart
reviewed
Oct 25, 2022
There was a problem hiding this comment.
I think I'm not up to speed, can we just delete this code altogether instead of commenting it out? My understanding is this is a temporary branch until we have more smart wallet features to get the dapps working again.
There's also the SmartWalletConnection component and all the logic for code splitting in Provider.jsx that we can remove.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Just remove the broken smart wallet support from the
community-devbranch, since the actual smart wallet is available in master.Security Considerations
Documentation Considerations
Testing Considerations