Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(agoric-cli): proposeChangeMintLimit #6278

Merged
merged 4 commits into from
Sep 20, 2022
Merged

Conversation

dckc
Copy link
Member

@dckc dckc commented Sep 19, 2022

refs: #6108

Description

add an agops psm proposeChangeMintLimit command.

Security Considerations

can't think of any; this just makes things that were previously possible somewhat easier.

Documentation Considerations

Notes on using proposePauseOffers are added to
https://github.com/Agoric/agoric-sdk/blob/master/packages/agoric-cli/test/agops-governance-smoketest.sh

This is purely a client; no chain-side changes to prompt upgrade considerations.

Testing Considerations

tested manually as far as seeing the question posted:

agoric follow :published.committees.Initial_Economic_Committee.latestQuestion ``` $ agoric follow :published.committees.Initial_Economic_Committee.latestQuestion { closingRule: { deadline: 1663627279n, timer: slot(0,"Alleged: timerService"), }, counterInstance: slot(1,"Alleged: InstanceHandle"), electionType: "param_change", issue: { contract: slot(2,"Alleged: InstanceHandle"), spec: { changes: { MintLimit: { brand: slot(3,"Alleged: IST brand"), value: 10000000000n, }, }, paramPath: { key: "governedApi", }, }, }, maxChoices: 1, method: "unranked", positions: [ { changes: { MintLimit: { brand: slot(3), value: 10000000000n, }, }, }, { noChange: [ "MintLimit", ], }, ], questionHandle: slot(4,"Alleged: QuestionHandle"), quorumRule: "majority", tieOutcome: { noChange: [ "MintLimit", ], }, } ```

Copy link
Member

@turadg turadg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. I'd suggest putting your new docs in the smoketest shell script. I expect anyone using that file is running commands one-by-one and reading them so it doesn't hurt to have more cases covered.

@dckc dckc added the automerge:squash Automatically squash merge label Sep 20, 2022
@mergify mergify bot merged commit 7165dea into master Sep 20, 2022
@mergify mergify bot deleted the dc-propose-mint-limit branch September 20, 2022 08:33
turadg pushed a commit that referenced this pull request Sep 30, 2022
* feat(agoric-cli): proposeChangeMintLimit

* docs(agoric-cli): doc/test for changing PSM MintLimit

* fixup! feat(agoric-cli): proposeChangeMintLimit

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:squash Automatically squash merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants