Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

walletFactory misc #6178

Merged
merged 3 commits into from
Sep 11, 2022
Merged

walletFactory misc #6178

merged 3 commits into from
Sep 11, 2022

Conversation

turadg
Copy link
Member

@turadg turadg commented Sep 11, 2022 •
edited
Loading

Description

  • Makes wallets unreachably durable. This isn't needed until next launch (make Smart Wallet contract durable #5894) but enabling it gives greater assurance of virtualization.
  • validate smartWallet init args
  • decide not to match canonical DepositFacet

Security Considerations

--

Documentation Considerations

--

Testing Considerations

  • Use the Chain deployment test to check the durability, using automerge label

@turadg turadg added the automerge:no-update (expert!) Automatically merge without updates label Sep 11, 2022
dckc
dckc approved these changes Sep 11, 2022
View reviewed changes
Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks plausible

I don't know these APIs well, so you might do well do stand by to hear from @Chris-Hibbert

@dckc
Copy link
Member

dckc commented Sep 11, 2022

Oh. automerge. so I suppose you're pretty confident. fair enough.

@mergify mergify bot merged commit 7660be9 into master Sep 11, 2022
@mergify mergify bot deleted the ta/walletFactory-misc branch September 11, 2022 20:00
@turadg turadg mentioned this pull request Sep 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dckc dckc dckc approved these changes

@Chris-Hibbert Chris-Hibbert Awaiting requested review from Chris-Hibbert

Assignees
No one assigned
Labels
automerge:no-update (expert!) Automatically merge without updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turadg @dckc