feat: save PSM adminFacet in bootstrap #6101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally, the contractGovernor will now make the adminFacet available.
turadg
requested changes
Aug 31, 2022
| @@ -40,6 +40,15 @@ const sanitizePathSegment = name => { | |||
| return candidate; | |||
| }; | |||
|
|
|||
| /** | |||
| * There's an obsolete version in utils.d.ts | |||
There was a problem hiding this comment.
please put these updates there instead so there's one correct one and no incorrect ones.
type AdminFacet = {
getVatShutdownPromise: () => Promise<any>; // Completion, which is currently any
upgradeContract: (contractBundleId: string, newPrivateArgs: any) => void;
restartContract: (newPrivateArgs: any) => void;
};| const creatorFacet = E(governorFacets.creatorFacet).getCreatorFacet(); | ||
|
|
||
| psmInstanceR.resolve(governedInstance); | ||
| psmInstanceR.resolve(await E(governorFacets.creatorFacet).getInstance()); |
There was a problem hiding this comment.
with all these facets, consider having a single entity in the space that is the result of zoe.startInstance.
There was a problem hiding this comment.
yeah; we tried that... ran into problems around promises or something... the answer isn't obvious, so we agreed to defer.
dckc
approved these changes
Aug 31, 2022
| @@ -281,6 +282,7 @@ const start = async (zcf, privateArgs) => { | |||
| voteOnApiInvocation, | |||
| voteOnOfferFilter: voteOnFilter, | |||
| getCreatorFacet: () => limitedCreatorFacet, | |||
| getAdminFacet: () => adminFacet, | |||
There was a problem hiding this comment.
This gave me some pause... we talked it over with @erights and agreed it's appropriate.
turadg
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #6100
Description
Save the PSM adminFacet from bootstrap. Also, the contractGovernor will now make the adminFacet available when other contracts need it.
Security Considerations
The admin facet is very powerful. The bootstrap environment is considered a secure context in which to hold powerful facets for the Econ Committee's use.
Documentation Considerations
None.
Testing Considerations
deferred to #6099.