Pass baggage in ZCF through buildRootObject to start() #5658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erights
approved these changes
Jun 24, 2022
Comment on lines
+51
to
+53
| const contractBaggage = provide(baggage, 'contractBaggage', () => | ||
| makeScalarBigMapStore('zoeContract'), | ||
| ); |
There was a problem hiding this comment.
Suggested change
| const contractBaggage = provide(baggage, 'contractBaggage', () => | |
| makeScalarBigMapStore('zoeContract'), | |
| ); | |
| const contractBaggage = provideDurableMapStore(baggage, 'contractBaggage'); |
| @@ -11,5 +11,6 @@ | |||
| * instanceRecordFromZoe: InstanceRecord, | |||
| * issuerStorageFromZoe: IssuerRecords, | |||
| * privateArgs?: object, | |||
| * baggage?: MapStore<string,any>, | |||
There was a problem hiding this comment.
Also the startContract implementation in zcfZygote, right?
Chris-Hibbert
force-pushed
the
cth-durable-zoe
branch
4 times, most recently
from
bf46bdb to
3333d60
Compare
|
#5635 will include what's necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #5593
refs: #5635
Description
Pass the
baggageprovided tobuildRootObject()tostartContract(), which callsstart(), to make it available to the zoe contract.Security Considerations
contract has its own sub-baggage.
Documentation Considerations
When we write up durability, the Zoe contract interface needs to mention that the baggage comes in a separate argument after
privateArgs.Testing Considerations
We'll need a test showing upgrade of a contract, but we already knew that.