Vault test refactor #5103
Merged
Vault test refactor #5103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
approved these changes
Apr 13, 2022
| const debugTick = (...args) => { | ||
| console.log(key, (debugCount += 1), ...args); | ||
| const debugTick = (optLog, ...args) => { | ||
| if (optLog.log) { |
There was a problem hiding this comment.
I hope we find time after MN-1 to rationalize logging. I don't think we have a ticket yet for that per se. #1318 is to do research.
| @@ -157,6 +157,7 @@ export const makeVaultManager = ( | |||
| liquidationInProgress = false; | |||
| // XXX should notify interested parties | |||
| console.error('liquidateAndRemove failed with', e); | |||
| throw e; | |||
There was a problem hiding this comment.
non-blocking: this is out of scope.
| @@ -68,13 +68,14 @@ const liquidate = async ( | |||
| collateralBrand, | |||
| ); | |||
|
|
|||
| // XXX problems with upgrade | |||
There was a problem hiding this comment.
gratuitous removal. this is still true.
dtribble
added
the
automerge:no-update
Chris-Hibbert
approved these changes
Apr 13, 2022
dtribble
removed
the
automerge:no-update
|
@Chris-Hibbert I had included the new |
* turn off unneeded tracing * pass `debt` to liquidation as an offerArg * add trace info in liquidation
* add test/support.js for test helpers * consolidate `makeBundle` and `setupZoeForTest` * make `setupZoeForTest` sync and return promises * add bootstrap `space` setup helper Refactor vault tests: * add `test.before` for shared setup * use `t.context` pervasively for shared and default config * change methods to override `t.context` before invoking `setupServices` * use `econ-behaviors` directly * move `addVaultType` into shared setup * eliminate governance terms
* deleted accidental pre-release stuff * added additional type declarations
* introduce `manualPriceAuthority` for tests * use manualPriceAuthority for example test * further DRY test code
dtribble
force-pushed
the
vault_test_refactor
branch
from
18eebf4 to
744e524
Compare
Chris-Hibbert
approved these changes
Apr 14, 2022
|
|
||
| priceAuthority.setPrice(makeRatio(677n, runBrand, 900n, aethBrand)); | ||
| trace(t, 'price dropped a little'); | ||
| // await manualTimer.tick(); |
There was a problem hiding this comment.
any reason to leave these tick()s here long term?
There was a problem hiding this comment.
nope. I'll clean that up in a future PR.
dtribble
added
the
automerge:no-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #4568
Description
Refactor test support into shared module
makeBundleandsetupZoeForTestsetupZoeForTestsync and return promisesspacesetup helperRefactor vault tests:
test.beforefor shared setupt.contextpervasively for shared and default configt.contextbefore invokingsetupServicesecon-behaviorsdirectlyaddVaultTypeinto shared setupSecurity Considerations
N/A
Documentation Considerations
N/A
Testing Considerations
This simplifies setup for RUN tests, and dramatically reduces duplicate code and setup in vault tests especially. It also reduces some redundant work in tests like creation of a new Zoe for each independent test. Additional shared overhead is now possible via
test.before