Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(swingset): make test less sensitive to changes in metering #3546

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

warner
Copy link
Member

@warner warner commented Jul 27, 2021

This changes test-dynamic-vat-metered.js to be more adaptive to changes in
the number of computrons consumed by the test function, by setting the
capacity and notification thresholds to be between small integral multiples
of a measured usage, instead of hard-coded values.

refs #3308
fixes #3538

@warner warner added SwingSet package: SwingSet metering charging for execution (was: package: tame-metering and transform-metering) labels Jul 27, 2021
@warner warner added this to the Testnet: Metering Phase milestone Jul 27, 2021
@warner warner requested review from erights and FUDCo July 27, 2021 19:59
@warner warner self-assigned this Jul 27, 2021
Copy link
Contributor

@FUDCo FUDCo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Credible.

@warner warner removed the request for review from erights July 27, 2021 21:53
@warner
Copy link
Member Author

warner commented Jul 27, 2021

@erights said this worked for him

@warner warner force-pushed the 3538-metering-test branch from 56df985 to a0806ef Compare July 27, 2021 21:54
@kriskowal
Copy link
Member

Verified that this works with the latest Endo versions. 🙏

This changes test-dynamic-vat-metered.js to be more adaptive to changes in
the number of computrons consumed by the test function, by setting the
capacity and notification thresholds to be between small integral multiples
of a measured usage, instead of hard-coded values.

refs #3308
fixes #3538
@warner warner force-pushed the 3538-metering-test branch from a0806ef to 91ecea3 Compare July 28, 2021 06:41
@warner warner enabled auto-merge (rebase) July 28, 2021 06:59
@warner warner merged commit e741be3 into master Jul 28, 2021
@warner warner deleted the 3538-metering-test branch July 28, 2021 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
metering charging for execution (was: package: tame-metering and transform-metering) SwingSet package: SwingSet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metering test gives different results locally (for markm) vs under CI
3 participants