feat(swingset): drop Presences, trigger syscall.dropImports
#3164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I recommend looking at the two commits separately, since the first one is mostly mechanical. |
warner
force-pushed
the
2724-drop-presences
branch
2 times, most recently
from
6f75c44 to
866ffd1
Compare
FUDCo
approved these changes
May 25, 2021
warner
force-pushed
the
2724-drop-presences
branch
from
866ffd1 to
ae2a070
Compare
warner
force-pushed
the
3147-remove-safety-pins
branch
from
916afe4 to
74a087c
Compare
warner
force-pushed
the
2724-drop-presences
branch
from
ae2a070 to
0a50a3b
Compare
warner
force-pushed
the
3147-remove-safety-pins
branch
from
74a087c to
a6ee724
Compare
warner
force-pushed
the
2724-drop-presences
branch
from
0a50a3b to
3dda4a8
Compare
This will be needed shortly for liveslots to drive GC during each crank.
Change liveslots to provoke GC at mid-crank, then process the "dead set" and emit `syscall.dropImports` for everything we can. For now, we conservatively assume that everything remains recognizable, so we do *not* emit `syscall.retireImport` for anything. The vref might be used as a WeakMap/WeakSet key, and the VOM isn't yet tracking those. When #3161 is done, we'll change liveslots to ask the VOM about each vref, and retire the ones it does not know how to recognize (which will hopefully be the majority of them). closes #3147 refs #2615 refs #2660
warner
force-pushed
the
2724-drop-presences
branch
from
3dda4a8 to
84e383a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change liveslots to provoke GC at mid-crank, then process the "dead set" and
emit
syscall.dropImportsfor everything we can.For now, we conservatively assume that everything remains recognizable, so we
do not emit
syscall.retireImportfor anything. The vref might be used asa WeakMap/WeakSet key, and the VOM isn't yet tracking those. When #3161 is
done, we'll change liveslots to ask the VOM about each vref, and retire the
ones it does not know how to recognize (which will hopefully be the majority
of them).
closes #3147
refs #2615
closes #2660
also closes #2243