Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load virtual objects when accessed, not when deserialized #2957

Merged
merged 1 commit into from
Apr 25, 2021

Conversation

FUDCo
Copy link
Contributor

@FUDCo FUDCo commented Apr 24, 2021

This is a step towards making virtual object references comparable with === by managing representatives using weak refs (see #1968)

@FUDCo FUDCo added enhancement New feature or request SwingSet package: SwingSet labels Apr 24, 2021
@FUDCo FUDCo requested a review from warner April 24, 2021 07:43
@FUDCo FUDCo self-assigned this Apr 24, 2021
Copy link
Member

@warner warner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Consider the test suggestion, but feel free to land with or without it.

@FUDCo FUDCo force-pushed the virtual-objects-deterministic-load branch from abd8ea7 to 9f5aaa8 Compare April 25, 2021 19:39
@FUDCo FUDCo enabled auto-merge (rebase) April 25, 2021 19:39
@FUDCo FUDCo merged commit 5e659e6 into master Apr 25, 2021
@FUDCo FUDCo deleted the virtual-objects-deterministic-load branch April 25, 2021 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request SwingSet package: SwingSet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants