chore: u18 cherrypicks round 6 #10711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs: #10680 ## Description We misplaced the adminFacets that would allow us to manage Auctions after they've been replaced and were about to do it again. The auctions were [last upgraded](https://github.com/Agoric/agoric-sdk/blob/43345a561fbdf7621c369abb15e6839f7c696565/packages/inter-protocol/src/proposals/add-auction.js#L157) in `agoric-upgrade-16av`. That code fails to save the instance's adminFacet, and only stores the contractKit in bootstrap promise space under the name `auctioneerKit`, where it will be overwritten on upgrade. Our other contracts now save a copy of the `contractKit` in either `contractKits` or `governedContractKits`, indexed by the instance, so the facets will hang around. This saves the old auctioneer during upgrade so we can manage it later (upgrade, terminate, change parameters). ### Security Considerations Losing our last handle for vats is a problem. ### Scaling Considerations We're upgrading vats to deal with scaling. ### Documentation Considerations None. ### Testing Considerations there was a test in #10680 which looked for this kit in `governedContractKits`, but I commented it out when it didn't succeed. It succeeds now. ### Upgrade Considerations Yes.
…10696) ## Description @warner asked for a proposal that would ensure there were several more (300 was settled on) arbitrary calls in order to provoke bring-out-your-dead. ### Security Considerations test environments only: aimed at mainFork. ### Scaling Considerations No implications ### Documentation Considerations Unnecessary ### Testing Considerations For test environments. ### Upgrade Considerations None.
## Description Update `cosmos-sdk` dependency to newly tagged Agoric version, `v0.46.16-alpha.agoric.2.5` ### Security Considerations Improves decoding of deeply nested transaction data. ### Scaling Considerations n/a ### Documentation Considerations n/a ### Testing Considerations Should be drop-in replacement for current dependencies. ### Upgrade Considerations n/a
Muneeb147
reviewed
Dec 17, 2024
There was a problem hiding this comment.
@mujahidkay Changes look good and I don't see anything missing or misaligned in cherry-picks from the original master commits. Let's see what CI tells us now
CI failed again. Investigating. |
Deploying agoric-sdk with
|
| Latest commit: |
540d4b1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://78b3c91b.agoric-sdk.pages.dev |
| Branch Preview URL: | https://mk-u18-rc5-cherrypicks.agoric-sdk.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry-picks the following commits from master:
No new upgrade name has been added.
Using following rebase todo: