Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade-18 cherry-picks round 3 #10547

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

mujahidkay
Copy link
Member

Description

Cherry-picks the following commit(s) from master:

Does not include a new upgrade name - we can recreate mainfork/ollinet from snapshot for verification, and rc1 didn't go to emerynet yet so we can reuse the previous upgrade name.

@mujahidkay mujahidkay requested a review from a team as a code owner November 21, 2024 02:06
@mujahidkay mujahidkay added the force:integration Force integration tests to run on PR label Nov 21, 2024
@mujahidkay mujahidkay self-assigned this Nov 21, 2024
Copy link

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: cd7bf4f
Status: ✅  Deploy successful!
Preview URL: https://1e11bfda.agoric-sdk.pages.dev
Branch Preview URL: https://mk-u18-cherrypick-r3-v3.agoric-sdk.pages.dev

View logs

@mujahidkay mujahidkay requested a review from mhofman November 21, 2024 02:24
Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I found https://github.com/Agoric/agoric-sdk/compare/mk/u18-cherrypick-round3..mk/u18-cherrypick-r3-v3 was helpful in showing there are no diffs with the previous attempt.

@mujahidkay mujahidkay merged commit 6083a43 into dev-upgrade-18 Nov 21, 2024
85 checks passed
@mujahidkay mujahidkay deleted the mk/u18-cherrypick-r3-v3 branch November 21, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
force:integration Force integration tests to run on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants