Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade vaults and auctions with a coreEval #9887

Closed
Chris-Hibbert opened this issue Aug 14, 2024 · 0 comments · Fixed by #9911
Closed

Upgrade vaults and auctions with a coreEval #9887

Chris-Hibbert opened this issue Aug 14, 2024 · 0 comments · Fixed by #9911
Assignees
@Chris-Hibbert
Labels
auction contract-upgrade enhancement New feature or request Vaults VaultFactor (née Treasury)

Comments

@Chris-Hibbert
Copy link
Contributor

refs: #9748

There was a previous plan (#9748) to update vaults and auctions, as well as priceFeeds and scaledPriceAuthorities. This is a plan to update just vaults and auctions.

What is the Problem Being Solved?

Create a CoreEval to update Auctions and Vaults.

Description of the Design

Replace the auction contract with a new vat. Upgrade vaults so it continues to use the existing priceFeeds, and knows the new auction contract.

Security Considerations

Ensure liquidation works, and all the contracts are talking to their modern incarnations.

Scaling Considerations

Does not address the space leakage (#8400) in priceFeeds and scaledPriceAuthorities.

Test Plan

Test the new coreEval in A3P.

Upgrade Considerations

verify that inter-protocol components work after upgrade.
@Chris-Hibbert Chris-Hibbert added enhancement New feature or request contract-upgrade Vaults VaultFactor (née Treasury) auction labels Aug 14, 2024
@Chris-Hibbert Chris-Hibbert self-assigned this Aug 14, 2024
@dckc dckc mentioned this issue Aug 16, 2024
Merged
@Chris-Hibbert Chris-Hibbert mentioned this issue Aug 17, 2024
Merged
mergify bot added a commit that referenced this issue Aug 19, 2024
@mergify
fix(vaultFactory): don't prevent repayment based on DebtLimit (#9907)
c4520c5 
closes: #9837

## Description

DebtLimit should not impact a vault owner's ability to repay, so refine `checkDebtLimit` to succeed regardless of `debtLimit` if `toMint` is empty.

### Security / Scaling Considerations

none

### Testing Considerations

straightforward unit test that failed before the fix

### Upgrade / Documentation Considerations

Straightforward upgrade; no state changes. See:
 - #9887

This fix should be cited in release notes.
@mergify mergify bot closed this as completed in #9911 Aug 19, 2024
@mergify mergify bot closed this as completed in aaa0def Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Chris-Hibbert Chris-Hibbert

Labels
auction contract-upgrade enhancement New feature or request Vaults VaultFactor (née Treasury)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a coreEval for vaults auctions and test in a3p Agoric/agoric-sdk
1 participant
@Chris-Hibbert