Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add IssuerKeywordRecord to puppetGovernor #8350

Closed
Chris-Hibbert opened this issue Sep 18, 2023 · 0 comments · Fixed by #8351
Closed

add IssuerKeywordRecord to puppetGovernor #8350

Chris-Hibbert opened this issue Sep 18, 2023 · 0 comments · Fixed by #8351
Assignees
@Chris-Hibbert
Labels
enhancement New feature or request Governance Governance test

Comments

@Chris-Hibbert
Copy link
Contributor

What is the Problem Being Solved?

PuppetGovernor makes testing easier. It doesn't currently support passing an IssuerKeywordRecord through to the governed contract.

Description of the Design

Add IssuerKeywordRecord as an optional parameter to setUpGovernedContract.

Security Considerations

None

Scaling Considerations

None

Test Plan

Verify that it gets passed through, and doesn't impact other functionality.

Upgrade Considerations

testing only, so no impact.
@Chris-Hibbert Chris-Hibbert added enhancement New feature or request test Governance Governance labels Sep 18, 2023
@Chris-Hibbert Chris-Hibbert self-assigned this Sep 18, 2023
Chris-Hibbert added a commit that referenced this issue Sep 18, 2023
@Chris-Hibbert
feat: puppetGovernor pass the Issuerkeywordrecord through
509e6f7 
closes: #8350
This was referenced Sep 18, 2023
Merged
Merged
@mergify mergify bot closed this as completed in #8351 Sep 19, 2023
mergify bot pushed a commit that referenced this issue Sep 19, 2023
@Chris-Hibbert
feat: puppetGovernor pass the Issuerkeywordrecord through (#8351)
9f89f97 
closes: #8350
mhofman pushed a commit that referenced this issue Sep 26, 2023
@Chris-Hibbert @mhofman
feat: puppetGovernor pass the Issuerkeywordrecord through (#8351)
90f43ba 
closes: #8350
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Chris-Hibbert Chris-Hibbert

Labels
enhancement New feature or request Governance Governance test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: puppetGovernor pass the IssuerKeywordRecord through Agoric/agoric-sdk
1 participant
@Chris-Hibbert