Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add liveslots tests of HandledPromise handler handoff #814

Closed
warner opened this issue Mar 31, 2020 · 1 comment
Closed

add liveslots tests of HandledPromise handler handoff #814

warner opened this issue Mar 31, 2020 · 1 comment
Assignees
Labels
eventual-send package: eventual-send SwingSet package: SwingSet

Comments

@warner
Copy link
Member

warner commented Mar 31, 2020

In @FUDCo 's PR for #766 we're seeing sharing-service test failures that probably have to do with pipelined messages causing liveSlots to attempt to re-use a retired Promise, probably because a HandledPromise closed over that vpid in one of its handlers. We believe the Presence's associated HandledPromise (the second HP) was supposed to have displaced that first HP, at least it should have replaced the handlers therein.

The task here is to add a unit test to test-liveslots.js that imports a promise, resolves it to a Presence, maybe gives it a turn to finish resolution, and then sends a message to the original promise. The syscall.send() thus created should be aimed at the presence, not the promise.

@warner
Copy link
Member Author

warner commented Apr 1, 2020

Done. The test fails (and is thus currently disabled), and the fix will happen under ticket #823

@warner warner closed this as completed Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eventual-send package: eventual-send SwingSet package: SwingSet
Projects
None yet
Development

No branches or pull requests

1 participant