Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Treasury to use Contract Governance to manage parameters #3473

Closed
Chris-Hibbert opened this issue Jul 14, 2021 · 0 comments · Fixed by #3310
Closed

Update Treasury to use Contract Governance to manage parameters #3473

Chris-Hibbert opened this issue Jul 14, 2021 · 0 comments · Fixed by #3310
Assignees
Labels
Core Economy OBSOLETE in favor of INTER-protocol enhancement New feature or request Governance Governance Inter-protocol Overarching Inter Protocol

Comments

@Chris-Hibbert
Copy link
Contributor

What is the Problem Being Solved?

Update the Treasury contract to manage parameters using Contract Governance (#3189).

Description of the Design

Contract Governance will provide a pluggable way to allow governance to control parameter values.

The Treasury contract should use this, splitting up the parameters for each form of collateral to use a separate manager, and one for the fees.

Security Considerations

Ensure that all the connections are visible and users and voters can verify everything.

Test Plan

a new SwingSet test that sets up votes on parameter changes.

@Chris-Hibbert Chris-Hibbert added enhancement New feature or request Beta Core Economy OBSOLETE in favor of INTER-protocol Inter-protocol Overarching Inter Protocol Governance Governance labels Jul 14, 2021
@Chris-Hibbert Chris-Hibbert added this to the Beta Phase 4: Governance milestone Jul 14, 2021
@Chris-Hibbert Chris-Hibbert self-assigned this Jul 14, 2021
@rowgraus rowgraus modified the milestones: Beta Phase 4: Governance, Testnet: Metering Phase Jul 28, 2021
@rowgraus rowgraus removed this from the Testnet: Metering Phase milestone Aug 12, 2021
Chris-Hibbert added a commit that referenced this issue Sep 20, 2021
extract params to a separate file
integrate contract governance into treasury
swingset test for treasury governance

closes #3189
closes #3473
Chris-Hibbert added a commit that referenced this issue Oct 1, 2021
extract params to a separate file
integrate contract governance into treasury
swingset test for treasury governance

closes #3189
closes #3473
Chris-Hibbert added a commit that referenced this issue Oct 1, 2021
extract params to a separate file
integrate contract governance into treasury
swingset test for treasury governance

closes #3189
closes #3473
Chris-Hibbert added a commit that referenced this issue Oct 2, 2021
extract params to a separate file
integrate contract governance into treasury
swingset test for treasury governance

closes #3189
closes #3473
Chris-Hibbert added a commit that referenced this issue Oct 2, 2021
extract params to a separate file
integrate contract governance into treasury
swingset test for treasury governance

closes #3189
closes #3473
Chris-Hibbert added a commit that referenced this issue Oct 6, 2021
extract params to a separate file
integrate contract governance into treasury
swingset test for treasury governance

closes #3189
closes #3473
Chris-Hibbert added a commit that referenced this issue Oct 7, 2021
extract params to a separate file
integrate contract governance into treasury
swingset test for treasury governance

closes #3189
closes #3473
@mergify mergify bot closed this as completed in #3310 Oct 8, 2021
mergify bot added a commit that referenced this issue Oct 8, 2021
* feat!: use contractGovernor to govern Treasury using ParamManager

extract params to a separate file
integrate contract governance into treasury
swingset test for treasury governance

closes #3189
closes #3473

* chore: minor cleanups: drop extra logs, standardize asserts, tsc fix

* chore: improve typescript declarations

* feat: add noAction electorate for assurance of no governance changes

* chore: validate() in test checks the installations

* fix: import types.js into params so bundle is usable in tests

* fix: remove spurious distinction in naming of Liquidity keyword

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mergify bot added a commit that referenced this issue Oct 8, 2021
* feat!: use contractGovernor to govern Treasury using ParamManager

extract params to a separate file
integrate contract governance into treasury
swingset test for treasury governance

closes #3189
closes #3473

* chore: minor cleanups: drop extra logs, standardize asserts, tsc fix

* chore: improve typescript declarations

* feat: add noAction electorate for assurance of no governance changes

* chore: validate() in test checks the installations

* fix: import types.js into params so bundle is usable in tests

* feat!: add a claimsRegistrar based on attestations

Agents who can deposit an attestation payment will get the ability to vote that amount.
refactor common registrat code to a library
tests that BinaryBallotCounter can count these votes.

* chore: review sugestions: types, cleanups, comments

* chore: better type decls, capitalize handles

more handles have capitalized names than not.

Suggestions from #3932

* fix: remove spurious distinction in naming of Liquidity keyword

* fix: handle<'attestation'> ==>  Handle<'Attestation'>

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Economy OBSOLETE in favor of INTER-protocol enhancement New feature or request Governance Governance Inter-protocol Overarching Inter Protocol
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants