Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(base-zone,zone): import
isPassable
from @endo/pass-style (#9230)
closes: #XXXX refs: endojs/endo#2096 endojs/endo#2042 ## Description Deleting @agoric/base-zone's implementation of `isPassable` completes the migration of `isPassable` from @agoric/base-zone to @endo/pass-style explained in endojs/endo#2096 and started in endojs/endo#2042 The remaining issue explained in endojs/endo#2096 , changing how `isPassable` is implemented, remains to be done in @endo/pass-style. But this need no longer concern us here since that difference will now be encapsulated from us. ### Security Considerations None ### Scaling Considerations We know that `passStyleOf` remains a performance hotspot that needs attention. This PR does not affect that at all. But I'll note that the remaining suggested change from endojs/endo#2096 --- to implement `isPassable` and `passStyleOf` in terms of a more expressive internal function parameterized by a checker --- might make this performance issue worse. Just something to keep in mind as we tune `passStyleOf`. Attn @gibson042 ### Documentation Considerations none ### Testing Considerations none ### Upgrade Considerations As of this PR, @agoric/base-zone also no longer exports `isPassable`, potentially breaking importers outside agoric-sdk until they are modified to import it from @endo/pass-style as well. This PR does take care of all such import sites within agoric-sdk. If this turns out to be a problem in practice, this PR could be changed to have @agoric/base-zone reexport the `isPassable` it imports from @endo/pass-style, but deprecate that reexport, leaving it to future work to change those old import sites outside agoric-sdk. --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
- Loading branch information