Skip to content

Commit

Permalink
fix(xsnap): use newer xsnap-pub, with requirement for __has_builtin
Browse files Browse the repository at this point in the history
This switches to a version of `xsnap-pub` that adds a compile-time
assertion of the availability of `__has_builtin()`. This function was
added to gcc-10, and was missing in gcc-9. XS can produce different
heap snapshots depending upon whether this function is available or
not (breaking consensus, which includes the heap snapshot hashes). By
mandating its presence, we ensure that all instances will behave the
same way, maintaining consensus.

closes #7829
  • Loading branch information
warner committed May 24, 2023
1 parent 24e09d8 commit 99de101
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ to use.
* Node.js LTS (version 14.15.0 or higher)
* we generally support the latest LTS release: use [nvm](https://github.com/nvm-sh/nvm) to keep your local system up-to-date
* Yarn (`npm install -g yarn`)
* gcc-10 or newer, or a compiler with `__has_builtin()`

Any version of Yarn will do: the `.yarnrc` file should ensure that all
commands use the specific checked-in version of Yarn (stored in
Expand Down
2 changes: 1 addition & 1 deletion packages/xsnap/build.env
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
MODDABLE_URL=https://github.com/agoric-labs/moddable.git
MODDABLE_COMMIT_HASH=46bbad5b8aa746c50b5f97aee1b1f235ab2a5903
XSNAP_NATIVE_URL=https://github.com/agoric-labs/xsnap-pub
XSNAP_NATIVE_COMMIT_HASH=056faf8c8930a20659dd4eaa3ebfae3a8b464c7f
XSNAP_NATIVE_COMMIT_HASH=25abead6b762b49faee840aed5c544556112711a
2 changes: 1 addition & 1 deletion packages/xsnap/xsnap-native

0 comments on commit 99de101

Please sign in to comment.