Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(frontend)[Issue 2418]: Evaluation results cannot be downloaded as CSV #2430

Merged
merged 2 commits into from
Jan 26, 2025
Merged

(frontend)[Issue 2418]: Evaluation results cannot be downloaded as CSV #2430

merged 2 commits into from
Jan 26, 2025

Conversation

bekossy
Copy link
Member

@bekossy bekossy commented Jan 25, 2025

Description

Fixes the issue where clicking "Export as CSV" in the evaluation results view did not trigger a download.

Changes:

  • Installed @ag-grid-community/csv-export package
  • Registered CsvExportModule from @ag-grid-community/csv-export to enable CSV export
  • Updated dynamic import of AgGridReact to include required module registrations (ClientSideRowModelModule and CsvExportModule)

Related Issue

Closes #2418

@bekossy bekossy requested review from mmabrouk and ardaerzin January 25, 2025 11:31
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 25, 2025
@vercel Vercel
Copy link

vercel bot commented Jan 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 25, 2025 11:31am
agenta-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 25, 2025 11:31am

@dosubot dosubot bot added the Frontend label Jan 25, 2025
@bekossy bekossy linked an issue Jan 25, 2025 that may be closed by this pull request
[Bug] Evaluation results cannot be downloaded as CSV #2418
Open
ardaerzin
ardaerzin approved these changes Jan 25, 2025
View reviewed changes
Copy link
Contributor

@ardaerzin ardaerzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍 LGTM

@mmabrouk
Copy link
Member

Thanks @bekossy and @ardaerzin !
Has this been light QA'ed? I couldn't do it in oss.agenta since it's currently broken.

@ardaerzin
Copy link
Contributor

Thanks @bekossy and @ardaerzin !

Has this been light QA'ed? I couldn't do it in oss.agenta since it's currently broken.

@mmabrouk mine was a code review, but I'll do a light QA later today and let you know here

@mmabrouk
Copy link
Member

No worries @ardaerzin I can do it, as soon as it is possible to run an eval in agenta. Should be extremely easy to do.

@mmabrouk
Copy link
Member

Light QA'ed ✅

@mmabrouk mmabrouk merged commit 35bfc36 into dev Jan 26, 2025
5 of 6 checks passed
@mmabrouk mmabrouk mentioned this pull request Jan 26, 2025
Open
@bekossy bekossy deleted the Issue-2418/-Evaluation-results-cannot-be-downloaded-as-csv branch January 26, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ardaerzin ardaerzin ardaerzin approved these changes

@mmabrouk mmabrouk Awaiting requested review from mmabrouk

Assignees
No one assigned
Labels
Frontend size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Evaluation results cannot be downloaded as CSV
3 participants
@bekossy @mmabrouk @ardaerzin