Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of parsing map literal and query parameter #94

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

git-hulk
Copy link
Member

This closes #92

@coveralls
Copy link

coveralls commented Aug 26, 2024

Pull Request Test Coverage Report for Build 10556180352

Details

  • 102 of 147 (69.39%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 59.29%

Changes Missing Coverage Covered Lines Changed/Added Lines %
parser/parser_table.go 4 6 66.67%
parser/ast_visitor.go 6 10 60.0%
parser/ast.go 41 55 74.55%
parser/parser_column.go 51 76 67.11%
Totals Coverage Status
Change from base Build 10522129953: 0.1%
Covered Lines: 6130
Relevant Lines: 10339

💛 - Coveralls

@git-hulk git-hulk requested a review from Lance726 August 26, 2024 08:13
@jsommr
Copy link

jsommr commented Aug 26, 2024

Not only did you resolve my issue (had not expected that) but wow - you did it within 24 hours. Really impressive! And super grateful for your work.

@git-hulk git-hulk merged commit 3ecb2c7 into AfterShip:master Aug 27, 2024
1 check passed
git-hulk added a commit to git-hulk/clickhouse-sql-parser that referenced this pull request Nov 29, 2024
@git-hulk git-hulk deleted the feature/query-parameter branch November 29, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support parameters
4 participants