Deduplicate fstar input in flake
#85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@msprotz are there cases where you would want to use a different version of fstar in eurydice than the one pinned by the karamel version you're using? |
|
Eurydice should not need F* |
|
Let me fix FStarLang/karamel#496 real quick |
|
Nice, ty |
|
Can we just merge this and you can remove the fstar input once it's not needed? |
|
The alternative is to export a dummy FSTAR_HOME, by the way, but this is really silly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flake pinned
fstarin two places (one directly and once inside karamel), which means if they ever got out of sync we'd have to build it twice. This instead reuses the pinned version in karamel.